Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OpenTracing to all Debian and Alpine based images #2581

Merged
merged 3 commits into from
Apr 22, 2022
Merged

Add OpenTracing to all Debian and Alpine based images #2581

merged 3 commits into from
Apr 22, 2022

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Apr 6, 2022 •
edited
Loading

Adds OpenTracing by default to all Debian based images (including NAP WAF and DoS) and all Alpine based images

@lucacome lucacome added the proposal An issue that proposes a feature request label Apr 6, 2022
@lucacome lucacome requested review from a team April 6, 2022 20:54
@lucacome lucacome self-assigned this Apr 6, 2022
@github-actions github-actions bot added documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements labels Apr 6, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2022 •
edited
Loading

Codecov Report

Merging #2581 (d2ba998) into main (31d7f33) will increase coverage by 0.04%.
The diff coverage is n/a.

❗ Current head d2ba998 differs from pull request most recent head 2970779. Consider uploading reports for the commit 2970779 to get more accurate results

@@            Coverage Diff             @@
##             main    #2581      +/-   ##
==========================================
+ Coverage   53.43%   53.47%   +0.04%     
==========================================
  Files          52       49       -3     
  Lines       14696    14299     -397     
==========================================
- Hits         7853     7647     -206     
+ Misses       6581     6409     -172     
+ Partials      262      243      -19
Impacted Files Coverage Δ
internal/configs/config_params.go 76.74% <0.00%> (ø)
internal/certmanager/sync.go
internal/certmanager/helper.go
internal/certmanager/cm_controller.go
internal/k8s/controller.go 10.90% <0.00%> (+0.03%) ⬆️
cmd/nginx-ingress/main.go 6.98% <0.00%> (+0.12%) ⬆️
pkg/apis/configuration/validation/virtualserver.go 96.24% <0.00%> (+1.50%) ⬆️
pkg/apis/configuration/validation/policy.go 96.55% <0.00%> (+2.12%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@lucacome lucacome force-pushed the feat/add-opentracing-debian-alpine branch 2 times, most recently from d2ba998 to 4b27cd3 Compare April 12, 2022 04:03
@lucacome lucacome force-pushed the feat/add-opentracing-debian-alpine branch from 4b27cd3 to 7c6eeb1 Compare April 13, 2022 01:18
@lucacome lucacome force-pushed the feat/add-opentracing-debian-alpine branch from 2970779 to ab9df9f Compare April 21, 2022 13:18
@jputrino
Copy link
Contributor

deploy preview for the docs changes looks good, thanks @lucacome !

@lucacome lucacome merged commit 8706d5d into main Apr 22, 2022
@lucacome lucacome deleted the feat/add-opentracing-debian-alpine branch April 22, 2022 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjngx jjngx jjngx approved these changes

@ciarams87 ciarams87 ciarams87 approved these changes

@jputrino jputrino jputrino approved these changes

@shaun-nx shaun-nx Awaiting requested review from shaun-nx shaun-nx was automatically assigned from nginxinc/kic

@brianehlert brianehlert Awaiting requested review from brianehlert

Assignees

@lucacome lucacome

Labels
documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements proposal An issue that proposes a feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lucacome @codecov-commenter @jputrino @ciarams87 @jjngx